Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to implement context sharing on Mac #1132

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Attempt to implement context sharing on Mac #1132

merged 2 commits into from
Apr 2, 2019

Conversation

tene
Copy link
Contributor

@tene tene commented Apr 1, 2019

I have no idea if this is the right thing to do or not, but with this patch I can run the sharing example.

I've never done any cocoa programming at all; I just followed the "Sharing Rendering Context Resources" section of https://developer.apple.com/library/archive/documentation/GraphicsImaging/Conceptual/OpenGL-MacProgGuide/opengl_contexts/opengl_contexts.html and did what seemed obvious, and I was surprised that it actually seemed to work.

I don't have another platform to run the examples on right now to actually check if the sharing example renders identically compared to other platforms.

This will contribute to #899

@goddessfreya
Copy link
Contributor

@tene Does the sharing example render the same as the window example?

You and @fschutt probably know more about this, so if it looks good to you folks, then it lgtm.

@tene
Copy link
Contributor Author

tene commented Apr 2, 2019

@zegentzy Yes, the sharing example and the window example look identical to me, except for different default window sizes.

@goddessfreya goddessfreya merged commit 7d345fa into rust-windowing:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants