Remove public reexports of HardwareBufferFormat
#436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously reexported from `hardware_buffer` in #276 to maintain backwards compatibility when the type was originally defined inside that module. However, the type was also strangely reexported from `native_window` (probably a copy-paste error) while it is accessible from the public `hardware_buffer_format` module leading to **three** individual modules where `HardwareBufferFormat` can be imported from. Reduce this duplication and confusion by forcing it to only be reachable from the canonical `hardware_buffer_format` module.
MarijnS95
force-pushed
the
remove-HardwareBufferFormat-reexports
branch
from
9e5ec25
to
7e2ebf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously reexported from
hardware_bufferin #276 to maintain backwards compatibility when the type was originally defined inside that module. However, the type was also strangely reexported fromnative_window(probably a copy-paste error) while it is accessible from the publichardware_buffer_formatmodule leading to three individual modules whereHardwareBufferFormatcan be imported from.Reduce this duplication and confusion by forcing it to only be reachable from the canonical
hardware_buffer_formatmodule.