native_window: Add format() getter and set_buffers_geometry() setter
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2022
msiglreith
approved these changes
May 29, 2022
MarijnS95
force-pushed
the
window-format
branch
2 times, most recently
from
df9c806
to
cee8500
Compare
… setter Android's `NativeWindow` allow querying the format through `ANativeWindow_getFormat` and setting it through `ANativeWindow_setBuffersGeometry` together with the dimensions to use for the buffer.
MarijnS95
added a commit
that referenced
this pull request
Oct 7, 2023
This was previously reexported from `hardware_buffer` in #276 to maintain backwards compatibility when the type was originally defined inside that module. However, the type was also strangely reexported from `native_window` (probably a copy-paste error) while it is accessible from the public `hardware_buffer_format` module leading to **three** individual modules where `HardwareBufferFormat` can be imported from. Reduce this duplication and confusion by forcing it to only be reachable from the canonical `hardware_buffer_format` module.
MarijnS95
added a commit
that referenced
this pull request
Oct 10, 2023
This was previously reexported from `hardware_buffer` in #276 to maintain backwards compatibility when the type was originally defined inside that module. However, the type was also strangely reexported from `native_window` (probably a copy-paste error) while it is accessible from the public `hardware_buffer_format` module leading to **three** individual modules where `HardwareBufferFormat` can be imported from. Reduce this duplication and confusion by forcing it to only be reachable from the canonical `hardware_buffer_format` module.
MarijnS95
added a commit
that referenced
this pull request
Oct 10, 2023
This was previously reexported from `hardware_buffer` in #276 to maintain backwards compatibility when the type was originally defined inside that module. However, the type was also strangely reexported from `native_window` (probably a copy-paste error) while it is accessible from the public `hardware_buffer_format` module leading to **three** individual modules where `HardwareBufferFormat` can be imported from. Reduce this duplication and confusion by forcing it to only be reachable from the canonical `hardware_buffer_format` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android's
NativeWindowallow querying the format throughANativeWindow_getFormatand setting it throughANativeWindow_setBuffersGeometrytogether with the dimensions to use for the buffer.