Remove "Skipping LLVM build" section #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`download-ci-llvm` is available and enabled by default for all tier 1 platforms, so there is no need to change it. Using system LLVM over CI llvm is still supported, but is not recommended. Building LLVM from source is still supported. This also notes that you need to explicitly disable downloading LLVM when updating the submodule.
|
Well, "enabled by default" if you set |
igaray
approved these changes
Jan 20, 2021
camelid
reviewed
Jan 21, 2021
Comment on lines
-218
to
-237
| Another alternative is to use LLVM already installed on your computer. This is | ||
| specified in the `target` section of `config.toml`: | ||
|
|
||
| ```toml | ||
| [target.x86_64-unknown-linux-gnu] | ||
| llvm-config = "/path/to/llvm/llvm-7.0.1/bin/llvm-config" | ||
| ``` | ||
|
|
||
| We have observed the following paths before, which may be different from your system: | ||
|
|
||
| - `/usr/bin/llvm-config-8` | ||
| - `/usr/lib/llvm-8/bin/llvm-config` | ||
|
|
||
| Note that you need to have the LLVM `FileCheck` tool installed, which is used | ||
| for codegen tests. This tool is normally built with LLVM, but if you use your | ||
| own preinstalled LLVM, you will need to provide `FileCheck` in some other way. | ||
| On Debian-based systems, you can install the `llvm-N-tools` package (where `N` | ||
| is the LLVM version number, e.g. `llvm-8-tools`). Alternately, you can specify | ||
| the path to `FileCheck` with the `llvm-filecheck` config item in `config.toml` | ||
| or you can disable codegen test with the `codegen-tests` item in `config.toml`. |
There was a problem hiding this comment.
@jyn514 Was this supposed to be removed?
There was a problem hiding this comment.
Yes, using system llvm is no longer recommended. There's a short section on it in config.toml.example, I don't think it needs its own section in the guide.
camelid
added a commit
to camelid/rustc-dev-guide
that referenced
this pull request
Feb 21, 2021
They were removed in rust-lang#1030, but are still useful.
jyn514
pushed a commit
that referenced
this pull request
Feb 26, 2021
They were removed in #1030, but are still useful.
pierwill
pushed a commit
that referenced
this pull request
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download-ci-llvmis available and enabled by default for all tier 1platforms (since rust-lang/rust#80932), so there is no need to change it.
Using system LLVM over CI llvm is still supported, but is not recommended. Building LLVM from
source is still supported.
This also notes that you need to explicitly disable downloading LLVM
when updating the submodule.