Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites page has link to nonexistent section of Suggested Workflows page #1278

Closed
rlee287 opened this issue Dec 21, 2021 · 4 comments · Fixed by #1282
Closed

Prerequisites page has link to nonexistent section of Suggested Workflows page #1278

rlee287 opened this issue Dec 21, 2021 · 4 comments · Fixed by #1282

Comments

@rlee287
Copy link

rlee287 commented Dec 21, 2021

The prerequisites page states that

Otherwise, you'll need LLVM installed and llvm-config in your path. See this section for more info.

Where "this section" is a link to https://rustc-dev-guide.rust-lang.org/building/suggested.html#skipping-llvm-build.

However, the Suggested Workflows page does not contain information on skipping the LLVM build. Can this link be corrected or removed?

(Incidentally, I'd like to know if it is possible to use the system LLVM instead of either building LLVM or downloading LLVM from Rust CI for building rustc. I wasn't able to find a definitive answer to this in the rustc-dev-guide.)

@ehuss
Copy link
Contributor

ehuss commented Dec 21, 2021

Essentially you just need to set llvm-config in config.toml.

It looks like it was removed in #1030. @jyn514 I think there are legitimate use cases for needing to use the system LLVM, and having some instructions won't hurt.

@jyn514
Copy link
Member

jyn514 commented Dec 21, 2021

Seems good! I won't have time to add it back for a while though.

@camelid
Copy link
Member

camelid commented Dec 22, 2021

I think I already re-added this section back in February. Is this what you were looking for? (Added in 2d42cf7.)

@rlee287
Copy link
Author

rlee287 commented Dec 22, 2021

Looks (to me, at least, since this is the first time I'm building rustc myself) like this does have the relevant information, in which case the link I mentioned should be changed to point to this section instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants