Make the lifetime accurate which is used in the region constraints part #96315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
|
📌 Commit 343523c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2022
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#96272 (Update `validate_uninhabited_zsts.rs` test after MIR building changes) - rust-lang#96273 (Make `E0117` error clear) - rust-lang#96315 (Make the lifetime accurate which is used in the region constraints part) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the FIXME about lifetime using in the region constraints part.
We cannot write
<'graph, 'tcx, D>because the definition ofSuccessors<'0, '1, D>requires'1 : '0.We cannot add bound to
'grapheither because'graphis required to be an arbitrary value in the definition ofWithSuccessorsSo the most accurate way is to use
<'s, 'tcx, D>.cc @Aaron1011 who added this FIXME in #85343