Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make E0117 error clear #96273

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Make E0117 error clear #96273

merged 2 commits into from
Apr 22, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Apr 21, 2022

closes #96227

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 21, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2022
davidtwco
davidtwco requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a comment.

compiler/rustc_typeck/src/coherence/orphan.rs Outdated Show resolved Hide resolved
@TaKO8Ki TaKO8Ki requested a review from davidtwco April 22, 2022 06:26
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 22, 2022

📌 Commit f5a8ee4 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2022
@bors
Auto merge of rust-lang#96322 - matthiaskrgr:rollup-9xejxrf, r=matthi…
f4ec0e7 
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#96272 (Update `validate_uninhabited_zsts.rs` test after MIR building changes)
 - rust-lang#96273 (Make `E0117` error clear)
 - rust-lang#96315 (Make the lifetime accurate which is used in the region constraints part)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b100c02 into rust-lang:master Apr 22, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 22, 2022
@TaKO8Ki TaKO8Ki deleted the make-E0117-error-clear branch April 23, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

Make "only traits defined in the current crate can be implemented for arbitrary types" less vague
5 participants
@TaKO8Ki @rust-highfive @davidtwco @bors @rustbot