Fix FIXME for generic_arg_infer in create_substs_for_ast_path
#91847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoxyUwU
added
the
A-const-generics
rust-highfive
added
the
S-waiting-on-review
|
❤️ |
|
📌 Commit 6c79595 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 13, 2021
…lcnr Fix FIXME for `generic_arg_infer` in `create_substs_for_ast_path` Fixes a FIXME, does some general refactoring of this fn, and also fixes a bug where we would use a const params defaults instead of an inference var ([playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=19456f65ea5dc3fcaa9b696f842ab380)) (lot of stuff in one PR but it was all so close together...) r? `@lcnr` Fixes rust-lang#91614
fmease
reviewed
Dec 13, 2021
| LL | let y = Mask::<_, _>::splat(false); | ||
| | - ^^^^^^^^^^^^^^^^^^^ cannot infer type for type parameter `T` | ||
| | | | ||
| | consider giving `y` the explicit type `Mask<_, LANES>`, where the type parameter `T` is specified |
There was a problem hiding this comment.
Suggested change
| | consider giving `y` the explicit type `Mask<_, LANES>`, where the type parameter `T` is specified | |
| | consider giving `y` the explicit type `Mask<T, LANES>`, where the type parameter `T` is specified |
Shouldn't the _ be T for the suggestion to make sense (in isolation)? It says consider giving […] the explicit type […], where the type parameter T is specified. In this case , it might not be ambiguous. However, when more type parameters are involved it would be. I remember there was some part in rustc which could handle this generically.
There was a problem hiding this comment.
Yea this error message is sort of weird (especially how it is _ for the type and LANES for the const despite both being inference var)
camelid
added
the
T-compiler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 13, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#91699 (Add `-webkit-appearance: none` to search input) - rust-lang#91846 (rustdoc: Reduce number of arguments for `run_test` a bit) - rust-lang#91847 (Fix FIXME for `generic_arg_infer` in `create_substs_for_ast_path`) - rust-lang#91849 (GATs outlives lint: Try to prove bounds) - rust-lang#91855 (Stabilize const_cstr_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a FIXME, does some general refactoring of this fn, and also fixes a bug where we would use a const params defaults instead of an inference var (playground)
(lot of stuff in one PR but it was all so close together...)
r? @lcnr
Fixes #91614