Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Reduce number of arguments for run_test a bit #91846

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Dec 13, 2021

  • rustdoc: Coalesce some run_test args as one LangString arg
  • Rename TestOptions to GlobalTestOptions
  • doctest: Rename options to rustdoc_options

It seems to apply to all doctests in the crate.
These are the rustdoc-wide options. It's easy to confuse them with
options for doctests in particular, so this change should help.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 13, 2021
@camelid
Copy link
Member Author

camelid commented Dec 13, 2021

r? @GuillaumeGomez

@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-doctests Area: Documentation tests, run by rustdoc C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Dec 13, 2021
@camelid camelid changed the title rustdoc: Reduce number of arguments for run_test rustdoc: Reduce number of arguments for run_test a bit Dec 13, 2021
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Dec 13, 2021

📌 Commit 9afa190 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 13, 2021
…eGomez

rustdoc: Reduce number of arguments for `run_test` a bit

- rustdoc: Coalesce some `run_test` args as one `LangString` arg
- Rename `TestOptions` to `GlobalTestOptions`
- doctest: Rename `options` to `rustdoc_options`
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2021
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#91699 (Add `-webkit-appearance: none` to search input)
 - rust-lang#91846 (rustdoc: Reduce number of arguments for `run_test` a bit)
 - rust-lang#91847 (Fix FIXME for `generic_arg_infer` in `create_substs_for_ast_path`)
 - rust-lang#91849 (GATs outlives lint: Try to prove bounds)
 - rust-lang#91855 (Stabilize const_cstr_unchecked)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dca8dde into rust-lang:master Dec 13, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 13, 2021
@camelid camelid deleted the doctest-cleanup branch December 13, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-doctests Area: Documentation tests, run by rustdoc C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants