Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust-analyzer #80984

Closed
wants to merge 1 commit into from
Closed

Update rust-analyzer #80984

wants to merge 1 commit into from

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Jan 13, 2021

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2021
@jonas-schievink
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 13, 2021

📌 Commit 61a6468 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2021
@lnicola lnicola mentioned this pull request Jan 15, 2021
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jan 16, 2021
@m-ou-se
Rollup merge of rust-lang#80984 - lnicola:bump-rust-analyzer, r=jonas…
ab62218 
…-schievink

Update rust-analyzer

to https://github.com/rust-analyzer/rust-analyzer/releases/tag/2021-01-11
@m-ou-se m-ou-se mentioned this pull request Jan 16, 2021
Closed
@m-ou-se
Copy link
Member

m-ou-se commented Jan 17, 2021 •
edited
Loading

@bors r-

This failed in #81102 (comment)

error: could not compile `salsa`

That seems to be a rust-analyzer dependency.

Full logs here: https://github.com/rust-lang-ci/rust/runs/1715493685

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 17, 2021
@lnicola
Copy link
Member Author

lnicola commented Jan 17, 2021

salsa compiles fine with the latest nightly. Could another PR have introduced those errors?

@lnicola
Copy link
Member Author

lnicola commented Jan 17, 2021

Probably #80732.

@m-ou-se
Copy link
Member

m-ou-se commented Jan 17, 2021

Could another PR have introduced those errors?

Maybe. I just searched for salsa because of that error message, which popped up a lot in rust-analyzer. Note that it failed on --target arm-unknown-linux-gnueabihf, which might be relevant.

If you think this PR is not the source of the problem, we can just try it again and see what happens.

@lnicola
Copy link
Member Author

lnicola commented Jan 17, 2021

The target seems less relevant, that looks like a type error. I tried cargo +nightly build --target arm-unknown-linux-gnueabihf on salsa 0.16 and it works.

I thought #80732 might be related to this because the test files say "ambigunous", but the error messages are not identical.

@lnicola
Copy link
Member Author

lnicola commented Jan 17, 2021

Confirmed in #80732 (comment).

@lnicola
Copy link
Member Author

lnicola commented Jan 17, 2021

This needs another bors r+, but there'll be another rust-analyzer release tagged tonight, so I suppose we can wait until that.

@m-ou-se
Copy link
Member

m-ou-se commented Jan 17, 2021

salsa 0.15.2 (the one used before this PR) compiles fine with #80732. So if you're not in a hurry, I'd prefer waiting a bit until we figured out if salsa 0.16 or #80732 is to blame, as only the combination of the two fails.

@jonas-schievink jonas-schievink mentioned this pull request Feb 1, 2021
Merged
@bors bors closed this in #81623 Feb 1, 2021
@lnicola lnicola deleted the bump-rust-analyzer branch February 1, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lnicola @rust-highfive @jonas-schievink @bors @m-ou-se @Mark-Simulacrum