Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize releases with updates to Rust repository submodule #7282

Closed
tweksteen opened this issue Jan 15, 2021 · 4 comments
Closed

Synchronize releases with updates to Rust repository submodule #7282

tweksteen opened this issue Jan 15, 2021 · 4 comments
Labels
S-actionable Someone could pick this issue up and work on it right now

Comments

@tweksteen
Copy link
Contributor

This was previously reported and fixed as a one-off in #5802. But the git submodule reference used in the Rust repository is now 4 months behind the release in this repository. That is, the preview available via rustup is outdated.

Would it be possible to add a step as part of the weekly release, to update the submodule reference in the main Rust repository? Or if weekly is too frequent, settle for a monthly update?

Thanks

@lnicola
Copy link
Member

lnicola commented Jan 15, 2021

You might have already seen it, but rust-lang/rust#80984 updates the RA submodule.

Ideally we'd make this happen automatically, though.

@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 18, 2021
@tweksteen
Copy link
Contributor Author

I wasn't, thanks for sharing the link.

Yes, automation would be best. It's also possible to have a manual step as part of the release process in the meantime (for instance, when writing down the ChangeLog).

@lnicola
Copy link
Member

lnicola commented Jan 18, 2021

I think there's an cargo xtask promote-release subcommand, but I haven't tried it.

Unfortunately, this still doesn't guarantee timely updates. My PR has been open for 5 days and will probably take that much again to get merged.

@Veykril
Copy link
Member

Veykril commented Nov 11, 2022

We are no longer a submodule of the rust repo but a subtree instead, I don't think automating that will work due to possible conflicts.

@Veykril Veykril closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

3 participants