Intra doc enum variant field #66704
Merged
Intra doc enum variant field #66704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
added
the
S-waiting-on-review
tesuji
reviewed
Nov 25, 2019
| let item = cx.tcx.inherent_impls(did) | ||
| .iter() | ||
| .flat_map(|imp| cx.tcx.associated_items(*imp)) | ||
| .find(|item| item.ident.name == variant_name); |
There was a problem hiding this comment.
iter.find().is_some() could be written as iter.any()
| match cx.tcx.type_of(did).kind { | ||
| ty::Adt(def, _) if def.is_enum() => { | ||
| if def.all_fields() | ||
| .find(|item| item.ident.name == variant_field_name).is_some() { |
27 tasks
|
Updated. |
kinnison
approved these changes
Nov 26, 2019
|
☔ The latest upstream changes (presumably #66675) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
intra-doc-enum-variant-field
branch
from
85f7992
to
e0bd51b
Compare
|
Updated! |
GuillaumeGomez
force-pushed
the
intra-doc-enum-variant-field
branch
2 times, most recently
from
11c495f
to
a636d70
Compare
GuillaumeGomez
force-pushed
the
intra-doc-enum-variant-field
branch
from
a636d70
to
97c427c
Compare
|
Ok, fixed the invalid errors return. We can move forward... @bors: r=kinnison |
|
📌 Commit 97c427c has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Nov 27, 2019
…nt-field, r=kinnison Intra doc enum variant field Part of rust-lang#43466. Add intra-doc link support for this: ```rust enum Foo { X { y: u8, // can be found with Foo::X::y } } ``` r? @kinnison
bors
added a commit
that referenced
this pull request
Nov 27, 2019
Rollup of 17 pull requests Successful merges: - #64325 (Stabilize nested self receivers in 1.41.0) - #66222 (Use `eq_opaque_type_and_type` when type-checking closure signatures) - #66305 (Add by-value arrays to `improper_ctypes` lint) - #66399 (rustc_metadata: simplify the interactions between Lazy and Table.) - #66534 (Allow global references via ForeignItem and Item for the same symbol name during LLVM codegen) - #66700 (Fix pointing at arg for fulfillment errors in function calls) - #66704 (Intra doc enum variant field) - #66718 (Refactor `parse_enum_item` to use `parse_delim_comma_seq`) - #66722 (Handle non_exhaustive in borrow checking) - #66744 (Fix shrink_to panic documentation) - #66761 (Use LLVMDisposePassManager instead of raw delete in rustllvm) - #66769 (Add core::{f32,f64}::consts::TAU.) - #66774 (Clean up error codes) - #66777 (Put back tidy check on error codes) - #66797 (Fixes small typo in array docs r? @steveklabnik) - #66798 (Fix spelling typos) - #66800 (Combine similar tests for const match) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43466.
Add intra-doc link support for this:
r? @kinnison