Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support anchors intra doc links #66675

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Support anchors intra doc links #66675

merged 4 commits into from
Nov 27, 2019

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 23, 2019 •
edited
Loading

Fixes #62833
Part of #43466.

cc @ollie27
r? @kinnison

kinnison
kinnison reviewed Nov 24, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly 👍

src/librustdoc/passes/collect_intra_doc_links.rs Outdated Show resolved Hide resolved
src/librustdoc/passes/collect_intra_doc_links.rs Outdated Show resolved Hide resolved
src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved
@nrc nrc mentioned this pull request Nov 24, 2019
Closed
27 tasks
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 24, 2019
Merged
@JohnTitor JohnTitor added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019
@GuillaumeGomez
Copy link
Member Author

Updated.

kinnison
kinnison reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These error message updates look good.

@kinnison
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 26, 2019

📌 Commit c1ea1fd has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 26, 2019
@Dylan-DPC-zz
Copy link

Rollup

@bors
Copy link
Contributor

bors commented Nov 27, 2019

⌛ Testing commit c1ea1fd with merge b5f265e...

bors added a commit that referenced this pull request Nov 27, 2019
@bors
Auto merge of #66675 - GuillaumeGomez:support-anchors-intra-doc-links…
b5f265e 
…, r=kinnison

Support anchors intra doc links

Fixes #62833
Part of #43466.

cc @ollie27
r? @kinnison
@bors
Copy link
Contributor

bors commented Nov 27, 2019

☀️ Test successful - checks-azure
Approved by: kinnison
Pushing b5f265e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 27, 2019
@bors bors merged commit c1ea1fd into rust-lang:master Nov 27, 2019
@bors bors mentioned this pull request Nov 27, 2019
Merged
@GuillaumeGomez GuillaumeGomez deleted the support-anchors-intra-doc-links branch November 27, 2019 09:20
@ehuss ehuss mentioned this pull request Nov 29, 2019
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Nov 29, 2019
@bors
Auto merge of #7641 - ehuss:fix-nightly-rustdoc-bad-link, r=Eh2406
c74ea1b 
Update tests for slight wording change in rustdoc error message.

Minor wording change in rustdoc error message from rust-lang/rust#66675.
@sollyucko sollyucko mentioned this pull request Jul 19, 2020
Merged
@jyn514 jyn514 mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison left review comments

Assignees

@kinnison kinnison

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anchors in intra doc link
5 participants
@GuillaumeGomez @kinnison @bors @Dylan-DPC-zz @JohnTitor