Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let LLVM 5 add DW_OP_deref to indirect args itself #47688

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Let LLVM 5 add DW_OP_deref to indirect args itself #47688

merged 1 commit into from
Jan 26, 2018

Commits on Jan 23, 2018

  1. Let LLVM 5 add DW_OP_deref to indirect args itself 

    We needed to manually added the `DW_OP_deref` ourselves in earlier LLVM,
but starting with [D31439] in LLVM 5, it appears that LLVM will always
handle this itself.  When we were still adding this manually, the
resulting `.debug_loc` had too many derefs, and this failed test
`debuginfo/by-value-self-argument-in-trait-impl.rs`.

[D31439]: https://reviews.llvm.org/D31439

Fixes rust-lang#47611.
cc @alexcrichton
r? @michaelwoerister
    @cuviper
    cuviper committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    7eb7d45 View commit details
    Browse the repository at this point in the history