Let LLVM 5 add DW_OP_deref to indirect args itself #47688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to manually added the
DW_OP_deref
ourselves in earlier LLVM,but starting with D31439 in LLVM 5, it appears that LLVM will always
handle this itself. When we were still adding this manually, the
resulting
.debug_loc
had too many derefs, and this failed testdebuginfo/by-value-self-argument-in-trait-impl.rs
.Fixes #47611.
cc @alexcrichton
r? @michaelwoerister