Add links for impls #43979
Add links for impls #43979
Conversation
Implements a solution for issue rust-lang#23552
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Can you post a screenshot of how the section anchor looks? |
| @@ -26,9 +26,6 @@ h1.fqn { | |||
| h2, h3:not(.impl):not(.method):not(.type):not(.tymethod), h4:not(.method):not(.type):not(.tymethod) { | |||
| border-bottom-color: #DDDDDD; | |||
| } | |||
| .in-band { | |||
| background-color: white; | |||
| } | |||
There was a problem hiding this comment.
Why did this style get taken out? Was it interfering with the anchor tag?
There was a problem hiding this comment.
Yes, the :target style is attempting to change the background to yellow, but the .in-band style is setting it back to white, creating a weird color layout.
Since the background for .in-band is typically white anyway, I thought it was reasonably safe to remove.
There was a problem hiding this comment.
Hmm, that makes sense, but i'm still gonna call in @GuillaumeGomez for a second opinion. (Usually he's supposed to get pinged on CSS changes but it looks like that one didn't happen this time >_>)
There was a problem hiding this comment.
There is a reason for this behavior. When the text of a function overlaps a version number, the version number isn't visible anymore to avoid weird text overlap. Normally, you could just put your own background-color after this one without issues.
There was a problem hiding this comment.
I just reverted my changes to main.css and I made the :target style look like this:
:target { background: #FDFFD3; background-color: #FDFFD3; }
Unfortunately, it doesn't solve the issue. Is this the change that you had in mind?
There was a problem hiding this comment.
Strange to have background and background-color and that your CSS change doesn't work...
There was a problem hiding this comment.
I have made a change that conserves the .in-band style here: 4729f22
|
Normal state: |
|
Thanks! I'm gonna wait to see what imperio thinks, but otherwise I like this! Thanks so much! |
:target will specifically override .in-band background
|
So were you able to find out what was wrong with background color? :) |
arielb1
added
the
S-waiting-on-author
|
I'm not really an expert on CSS, but my understanding was that the |
|
I think that's good. The CSS isn't ugly so it's fine for. Thanks a lot for the PR! @bors: r+ rollup |
|
📌 Commit 4729f22 has been approved by |
…umeGomez Add links for impls Implements a solution for issue rust-lang#23552 r? @QuietMisdreavus
Implements a solution for issue #23552
r? @QuietMisdreavus