Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc - Section Symbol in Wrong Location on Impls w/ Where Clauses #44120

Closed
Havvy opened this issue Aug 28, 2017 · 5 comments
Closed

Rustdoc - Section Symbol in Wrong Location on Impls w/ Where Clauses #44120

Havvy opened this issue Aug 28, 2017 · 5 comments
Assignees
@GuillaumeGomez
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Havvy
Copy link
Contributor

Havvy commented Aug 28, 2017

Real time example: Hover over this impl on vec.

The section symbol appears on its own line instead of somewhere on the impl itself.

cc @QuietMisdreavus @GuillaumeGomez
@GuillaumeGomez
Copy link
Member

Hum... Do you have an idea since when? It could help to understand where the issue is coming from instead of just fixing it.

@Havvy
Copy link
Contributor Author

Havvy commented Aug 28, 2017

I don't know when it started. I don't remember the last time I looked at the nightly docs. Tuesday was the latest possible time, but 🤷‍♂️.

@kennytm
Copy link
Member

kennytm commented Aug 28, 2017

@GuillaumeGomez The § thing doesn't appear in beta, so likely a bug in the initial implementation (I guess #43747).

@ollie27
Copy link
Member

ollie27 commented Aug 28, 2017

#43979 added the § for impls.

@GuillaumeGomez
Copy link
Member

Thanks @ollie27! Taking a look this evening.

@GuillaumeGomez GuillaumeGomez self-assigned this Aug 28, 2017
@carols10cents carols10cents added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Aug 28, 2017
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 28, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Aug 29, 2017
@frewsxcv
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
a5559ee 
…etMisdreavus

Fix invalid linker position

Fixes rust-lang#44120.

Result isn't "optimal" though because there are spaces at the end of some lines.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Aug 29, 2017
@frewsxcv
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
e4ee803 
…etMisdreavus

Fix invalid linker position

Fixes rust-lang#44120.

Result isn't "optimal" though because there are spaces at the end of some lines.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Aug 29, 2017
@frewsxcv
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
efa27ac 
…etMisdreavus

Fix invalid linker position

Fixes rust-lang#44120.

Result isn't "optimal" though because there are spaces at the end of some lines.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Aug 29, 2017
@frewsxcv
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
2c127b5 
…etMisdreavus

Fix invalid linker position

Fixes rust-lang#44120.

Result isn't "optimal" though because there are spaces at the end of some lines.
arielb1 pushed a commit to arielb1/rust that referenced this issue Aug 29, 2017
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
b7b5dbc 
…etMisdreavus

Fix invalid linker position

Fixes rust-lang#44120.

Result isn't "optimal" though because there are spaces at the end of some lines.
arielb1 pushed a commit to arielb1/rust that referenced this issue Aug 29, 2017
Rollup merge of rust-lang#44135 - GuillaumeGomez:fix-css-links, r=Qui…
588f833 
…etMisdreavus

Fix invalid linker position

Fixes rust-lang#44120.

Result isn't "optimal" though because there are spaces at the end of some lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kennytm @carols10cents @Havvy @GuillaumeGomez @ollie27