Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aarch64-unknown-freebsd #39491

Merged
merged 2 commits into from
Feb 5, 2017
Merged

Support aarch64-unknown-freebsd #39491

merged 2 commits into from
Feb 5, 2017

Conversation

dumbbell
Copy link
Contributor

@dumbbell dumbbell commented Feb 3, 2017

No description provided.

@dumbbell dumbbell changed the title Support aarch64 unknown freebsd Support aarch64-unknown-freebsd Feb 3, 2017
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dumbbell
Copy link
Contributor Author

dumbbell commented Feb 3, 2017

To test this patch, I cross-compiled Rust and Cargo on FreeBSD/x86_64. I used the result on FreeBSD/aarch64 to check that Rust could self-host.

This pull request goes with rust-lang/libc#512.

@dumbbell dumbbell mentioned this pull request Feb 3, 2017
Merged
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

cc @rust-lang/tools

@bors
Copy link
Contributor

bors commented Feb 3, 2017

📌 Commit f6c6b31 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
@frewsxcv
Rollup merge of rust-lang#39491 - dumbbell:support-aarch64-unknown-fr…
0e65bae 
…eebsd, r=alexcrichton

Support aarch64-unknown-freebsd
@frewsxcv frewsxcv mentioned this pull request Feb 5, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
@frewsxcv
Rollup merge of rust-lang#39491 - dumbbell:support-aarch64-unknown-fr…
b7b5d64 
…eebsd, r=alexcrichton

Support aarch64-unknown-freebsd
@frewsxcv frewsxcv mentioned this pull request Feb 5, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
@frewsxcv
Rollup merge of rust-lang#39491 - dumbbell:support-aarch64-unknown-fr…
b3518af 
…eebsd, r=alexcrichton

Support aarch64-unknown-freebsd
@frewsxcv frewsxcv mentioned this pull request Feb 5, 2017
Merged
bors added a commit that referenced this pull request Feb 5, 2017
@bors
Auto merge of #39567 - frewsxcv:rollup, r=frewsxcv
031c116 
Rollup of 12 pull requests

- Successful merges: #39439, #39472, #39481, #39491, #39501, #39509, #39514, #39519, #39526, #39528, #39530, #39538
- Failed merges:
@bors bors merged commit f6c6b31 into rust-lang:master Feb 5, 2017
@dumbbell dumbbell deleted the support-aarch64-unknown-freebsd branch February 5, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dumbbell @rust-highfive @alexcrichton @bors @nikomatsakis