Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for aarch64-unknown-freebsd #512

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

dumbbell
Copy link
Contributor

@dumbbell dumbbell commented Feb 3, 2017

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@dumbbell
Copy link
Contributor Author

dumbbell commented Feb 3, 2017

To test this patch, I cross-compiled Rust and Cargo on FreeBSD/x86_64. I used the result on FreeBSD/aarch64 to check that Rust could self-host.

This pull request goes with rust-lang/rust#39491.

`aarch64.rs` was copied and adapted from `x86_64.rs`.
@dumbbell dumbbell force-pushed the support-aarch64-unknown-freebsd branch from f2097ac to 1363fe4 Compare February 3, 2017 17:11
@alexcrichton
Copy link
Member

@bors: r+

Awesome!

@bors
Copy link
Contributor

bors commented Feb 3, 2017

📌 Commit 1363fe4 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 1363fe4 with merge 37a2f39...

bors added a commit that referenced this pull request Feb 3, 2017
…crichton

Add types for `aarch64-unknown-freebsd`
@bors
Copy link
Contributor

bors commented Feb 3, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Feb 3, 2017 via email

@bors
Copy link
Contributor

bors commented Feb 3, 2017

⌛ Testing commit 1363fe4 with merge 8d8264b...

bors added a commit that referenced this pull request Feb 3, 2017
…crichton

Add types for `aarch64-unknown-freebsd`
@bors
Copy link
Contributor

bors commented Feb 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8d8264b to master...

@bors bors merged commit 1363fe4 into rust-lang:master Feb 3, 2017
@dumbbell dumbbell deleted the support-aarch64-unknown-freebsd branch February 3, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants