Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbook chapters/sections should be an ordered list. #36130

Merged
merged 1 commit into from
Aug 31, 2016
Merged

rustbook chapters/sections should be an ordered list. #36130

merged 1 commit into from
Aug 31, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

These are in the left sidebar of the rustbook generated HTML.

@steveklabnik
Copy link
Member

Can you show what this looks like rendered? They're already numbered, I want to make sure that this isn't gonna end up screwing that up.

@frewsxcv
Copy link
Member Author

screen shot 2016-08-30 at 11 10 05 am

@steveklabnik
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2016

📌 Commit 10b8e0e has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36130 - frewsxcv:patch-32, r=steveklabnik
a5332d0 
rustbook chapters/sections should be an ordered list.
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
Rollup merge of rust-lang#36130 - frewsxcv:patch-32, r=steveklabnik
aa4bf9a 
rustbook chapters/sections should be an ordered list.
@sophiajt sophiajt mentioned this pull request Aug 30, 2016
Closed
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36130 - frewsxcv:patch-32, r=steveklabnik
9d2179c 
rustbook chapters/sections should be an ordered list.
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#36130 - frewsxcv:patch-32, r=steveklabnik
668a34d 
rustbook chapters/sections should be an ordered list.
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Merged
bors added a commit that referenced this pull request Aug 31, 2016
@bors
Auto merge of #36166 - jonathandturner:rollup, r=jonathandturner
7a187c3 
Rollup of 16 pull requests

- Successful merges: #35758, #35926, #36050, #36079, #36085, #36089, #36101, #36130, #36134, #36135, #36136, #36140, #36141, #36147, #36148, #36165
- Failed merges:
@bors bors merged commit 10b8e0e into rust-lang:master Aug 31, 2016
@frewsxcv frewsxcv deleted the patch-32 branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @steveklabnik @bors @aturon