add evocative examples for BitOr and BitXor
#35926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's slow down a bit here. There was an interesting debate on the nature of bitwise operations here: #35927. I plan to update |
|
I've taken the improvements in #35993 and applied them to this PR. I figured that a simple |
These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary "xor" operator in Rust, so here it's expressed as (a || b) && !(a && b). r? @GuillaumeGomez improved documentation a la PR rust-lang#35993
matthew-piziak
force-pushed
the
bit-or-xor-examples
branch
from
b70b459
to
8ca9fa1
Compare
|
Thanks! @bors: r+ rollup |
|
📌 Commit 8ca9fa1 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
… r=GuillaumeGomez add evocative examples for `BitOr` and `BitXor` These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as `(a || b) && !(a && b)`. Alternative decompositions are `(a && !b) || (!a && b)` and `(a || b) && (!a || !b)`. Let me know if you think one of those would be clearer. r? @GuillaumeGomez
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
… r=GuillaumeGomez add evocative examples for `BitOr` and `BitXor` These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as `(a || b) && !(a && b)`. Alternative decompositions are `(a && !b) || (!a && b)` and `(a || b) && (!a || !b)`. Let me know if you think one of those would be clearer. r? @GuillaumeGomez
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
… r=GuillaumeGomez add evocative examples for `BitOr` and `BitXor` These are exactly equivalent to PR rust-lang#35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as `(a || b) && !(a && b)`. Alternative decompositions are `(a && !b) || (!a && b)` and `(a || b) && (!a || !b)`. Let me know if you think one of those would be clearer. r? @GuillaumeGomez
bors
added a commit
that referenced
this pull request
Aug 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are exactly equivalent to PR #35809, with one caveat: I do not believe there is a non-bitwise binary XOR operator in Rust, so here it's expressed as
(a || b) && !(a && b).Alternative decompositions are
(a && !b) || (!a && b)and(a || b) && (!a || !b). Let me know if you think one of those would be clearer.r? @GuillaumeGomez