compiletest: detect nodejs binary, allow override #34236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than hardcoding the binary name for running asmjs tests, attempt to detect the name that should be used; either `nodejs` or `node`. Also add a command-line argument to manually specify what should be used, suppressing probing. Fixes rust-lang#34188.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| } | ||
| } | ||
| None | ||
| } |
There was a problem hiding this comment.
This may also be expressible as:
let path = env::var_os("PATH").unwrap_or(OsString::new());
env::split_paths(&path).flat_map(|p| {
vec![p.join("nodejs"), p.join("node"), p.join("nodejs.exe"), p.join("node.exe")]
}).filter(|p| {
p.exists()
}).next()It's ok to not really optimize this much but we probably want to also handle windows as well?
There was a problem hiding this comment.
Yeah, I forgot about Windows so at least the .exe variants should be added. I also considered trying to run each instead of scanning PATH, which would free us from needing to know about a platform's executable suffix so I think that's a better solution.
There was a problem hiding this comment.
Hm spawning processes here may be a bit expensive here so it may be best to just rely on file detection
|
Closing due to inactivity, but feel free to resubmit with Windows handled as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than hardcoding the binary name for running asmjs tests, attempt
to detect the name that should be used; either
nodejsornode. Alsoadd a command-line argument to manually specify what should be used,
suppressing probing.
Fixes #34188.