Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asmjs test runner should detect Node binary name #34188

Closed
tari opened this issue Jun 9, 2016 · 0 comments
Closed

asmjs test runner should detect Node binary name #34188

tari opened this issue Jun 9, 2016 · 0 comments

Comments

@tari
Copy link
Contributor

tari commented Jun 9, 2016

The test runner for asm.js targets currently always runs them via nodejs, but that name is not universal across distributions- in fact the official name for the Node binary is node. Debian (and presumably Debian derivatives) uses the former name due to a name conflict with another tool.

It would be good to support both via detection at runtime, probably preferring nodejs and trying node if that is not available. In the interest of performance, this should probably be tested only once per run, with a lazy static or similar. Reporting an error if neither is found would also be useful, rather than the current behavior of failing tests due to being unable to invoke the javascript engine.
@sanmai-NL sanmai-NL mentioned this issue Jun 10, 2016
Closed
tari added a commit to tari/rust that referenced this issue Jun 12, 2016
@tari
compiletest: detect nodejs binary, allow override
a27667a 
Rather than hardcoding the binary name for running asmjs tests, attempt
to detect the name that should be used; either `nodejs` or `node`. Also
add a command-line argument to manually specify what should be used,
suppressing probing.

Fixes rust-lang#34188.
@tari tari mentioned this issue Jun 12, 2016
Closed
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Nov 6, 2016
Merged
bors added a commit that referenced this issue Nov 12, 2016
@bors
Auto merge of #37611 - Mark-Simulacrum:tari-nodejs-runner-detect, r=a…
fd983d0 
…lexcrichton

compile-test: allow overriding nodejs binary location

Add a command-line argument to manually specify which nodejs binary should be used,
which disables the default search.

Original work done by @tari.

Fixes #34188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tari