docs: Improve char::to_{lower,upper}case examples #34165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect the results to a String to make it clear that it will not always return only one char and add examples showing that.
|
👍 (I'll let @steveklabnik take a look.) |
|
I like it too. Thanks! @bors: r+ rollup |
|
📌 Commit bc4def9 has been approved by |
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Jun 10, 2016
docs: Improve char::to_{lower,upper}case examples
Collect the results to a String to make it clear that it will not always
return only one char and add examples showing that.
r? @steveklabnik
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Jun 10, 2016
docs: Improve char::to_{lower,upper}case examples
Collect the results to a String to make it clear that it will not always
return only one char and add examples showing that.
r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect the results to a String to make it clear that it will not always
return only one char and add examples showing that.
r? @steveklabnik