Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run rustfmt on map.rs in libcollections/btree folder #34088

Merged
merged 1 commit into from
Jun 10, 2016
Merged

run rustfmt on map.rs in libcollections/btree folder #34088

merged 1 commit into from
Jun 10, 2016

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

gereeter
gereeter reviewed Jun 5, 2016
View reviewed changes
src/libcollections/btree/map.rs
}

impl<K, V> Drop for BTreeMap<K, V> {
#[unsafe_destructor_blind_to_params]
fn drop(&mut self) {
unsafe {
for _ in ptr::read(self).into_iter() { }
for _ in ptr::read(self).into_iter() {
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err... This looks weird and against standard Rust style to me.

@srinivasreddy
Copy link
Contributor Author

I am not really sure how many of these comments are bugs and expected behaviours. So over to @nrc. And not sure changing by hand worth it.

@nrc
Copy link
Member

nrc commented Jun 7, 2016

@bors: r+

(Some of the things @gereeter pointed out are certainly sub-optimal, but can be fixed by modifying rustfmt and re-formatting)

@bors
Copy link
Contributor

bors commented Jun 7, 2016

📌 Commit d6560dd has been approved by nrc

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 8, 2016
@Manishearth
Rollup merge of rust-lang#34088 - srinivasreddy:rustfmt_map.rs, r=nrc
11cd6b6 
run rustfmt on map.rs in libcollections/btree folder
@sanxiyn
Copy link
Member

sanxiyn commented Jun 8, 2016

@bors rollup

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jun 10, 2016
@sanxiyn
Rollup merge of rust-lang#34088 - srinivasreddy:rustfmt_map.rs, r=nrc
e1e193a 
run rustfmt on map.rs in libcollections/btree folder
@sanxiyn sanxiyn mentioned this pull request Jun 10, 2016
Closed
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jun 10, 2016
@sanxiyn
Rollup merge of rust-lang#34088 - srinivasreddy:rustfmt_map.rs, r=nrc
4f6e8f8 
run rustfmt on map.rs in libcollections/btree folder
@sanxiyn sanxiyn mentioned this pull request Jun 10, 2016
Merged
bors added a commit that referenced this pull request Jun 10, 2016
@bors
Auto merge of #34200 - sanxiyn:rollup, r=sanxiyn
a267d6c 
Rollup of 12 pull requests

- Successful merges: #34088, #34129, #34136, #34145, #34146, #34148, #34159, #34160, #34165, #34175, #34184, #34185
- Failed merges:
@bors bors merged commit d6560dd into rust-lang:master Jun 10, 2016
@srinivasreddy srinivasreddy deleted the rustfmt_map.rs branch June 10, 2016 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@srinivasreddy @rust-highfive @nrc @bors @sanxiyn @gereeter @brson