-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #34073
Rollup of 6 pull requests #34073
Commits on May 30, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 9b014ec - Browse repository at this point
Copy the full SHA 9b014ecView commit details
Commits on Jun 1, 2016
-
Rewrote "How Safe and Unsafe Interact" Nomicon chapter.
The previous version of the chapter covered a lot of ground, but was a little meandering and hard to follow at times. This draft is intended to be clearer and more direct, while still providing the same information as the previous version.
Andrew Brinker committedJun 1, 2016 Configuration menu - View commit details
-
Copy full SHA for 00e77d7 - Browse repository at this point
Copy the full SHA 00e77d7View commit details
Commits on Jun 2, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 8841f26 - Browse repository at this point
Copy the full SHA 8841f26View commit details
Commits on Jun 5, 2016
-
Configuration menu - View commit details
-
Copy full SHA for d6560dd - Browse repository at this point
Copy the full SHA d6560ddView commit details
Commits on Jun 6, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 0f37edb - Browse repository at this point
Copy the full SHA 0f37edbView commit details -
Remove a gotcha from book/error-handling.md
The book's "Error handling with Box<Error>" section talks about Box<Error>. In the actual example Box<Error + Send + Sync> is used instead so that the corresponding From impls could be used to convert a plain string to an error type. Rust 1.7 added support for conversion from &str/String to Box<Error>, so this gotcha and later references to it can now be removed.
Configuration menu - View commit details
-
Copy full SHA for 75fc40c - Browse repository at this point
Copy the full SHA 75fc40cView commit details
Commits on Jun 7, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 49de80d - Browse repository at this point
Copy the full SHA 49de80dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 970e15d - Browse repository at this point
Copy the full SHA 970e15dView commit details -
Fix issue rust-lang#34101: do not track subcontent of type with dtor …
…nor gather flags for untracked content. (Includes a regression test, which needed to go into `compile-fail/` due to weaknesses when combining `#[deny(warnings)]` with `tcx.sess.span_warn(..)`) (updated with review feedback from arielb1.)
Configuration menu - View commit details
-
Copy full SHA for 4b6a68e - Browse repository at this point
Copy the full SHA 4b6a68eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4504df7 - Browse repository at this point
Copy the full SHA 4504df7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7abdbd4 - Browse repository at this point
Copy the full SHA 7abdbd4View commit details -
Fixed based on feedback from steveklabnik
Andrew Brinker committedJun 7, 2016 Configuration menu - View commit details
-
Copy full SHA for af33b30 - Browse repository at this point
Copy the full SHA af33b30View commit details
Commits on Jun 8, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 0379493 - Browse repository at this point
Copy the full SHA 0379493View commit details -
Configuration menu - View commit details
-
Copy full SHA for c39e37a - Browse repository at this point
Copy the full SHA c39e37aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5439806 - Browse repository at this point
Copy the full SHA 5439806View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c5f3a6 - Browse repository at this point
Copy the full SHA 4c5f3a6View commit details -
Rollup merge of rust-lang#33895 - AndrewBrinker:master, r=steveklabnik
Rewrote "How Safe and Unsafe Interact" Nomicon chapter. The previous version of the chapter covered a lot of ground, but was a little meandering and hard to follow at times. This draft is intended to be clearer and more direct, while still providing the same information as the previous version. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for 25c5d92 - Browse repository at this point
Copy the full SHA 25c5d92View commit details -
Rollup merge of rust-lang#33931 - srinivasreddy:lint_folder, r=Guilla…
…umeGomez run rustfmt on librustc_lint folder
Configuration menu - View commit details
-
Copy full SHA for 94cae0a - Browse repository at this point
Copy the full SHA 94cae0aView commit details -
Rollup merge of rust-lang#34046 - Vtec234:fix-atomic-doc, r=steveklabnik
Fix wrong statement in compare_exchange doc The documentation for `core::sync::atomic::AtomicSomething::compare_exchange` contains a wrong, or imprecise, statement about the return value. It goes: The return value is a result indicating whether the new value was written and containing the previous value. On success this value is guaranteed to be equal to `new`. In the second sentence, `this value` is gramatically understood as referring to `return value` from the first sentence. Due to how CAS works, the returned value is always what was in the atomic variable _before_ the operation occurred, not what was written into it during the operation. Hence, the fixed doc should say: The return value is a result indicating whether the new value was written and containing the previous value. On success this value is guaranteed to be equal to `current`. This version is confirmed by the runnable examples in variants of `AtomicSomething`, e.g. assert_eq!(some_bool.compare_exchange(true, false, Ordering::Acquire, Ordering::Relaxed), Ok(true)); where the returned value is `Ok(current)`. This PR fixes all occurrences of this bug I could find. An alternative solution would be to modify the second sentence so that it refers to the value _written_ into the Atomic rather than what was there before, in which case it would be correct. Example alternative formulation: On success the value written into the `bool`/`usize`/`whatever` is guaranteed to be equal to `new`. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for 65c7425 - Browse repository at this point
Copy the full SHA 65c7425View commit details -
Rollup merge of rust-lang#34088 - srinivasreddy:rustfmt_map.rs, r=nrc
run rustfmt on map.rs in libcollections/btree folder
Configuration menu - View commit details
-
Copy full SHA for 11cd6b6 - Browse repository at this point
Copy the full SHA 11cd6b6View commit details -
Rollup merge of rust-lang#34108 - jseyfried:refactor_prelude_injectio…
…n, r=nrc Refactor away the prelude injection fold Instead, just inject `#[prelude_import] use [core|std]::prelude::v1::*;` at the crate root while injecting `extern crate [core|std];` and process `#[no_implicit_prelude]` attributes in `resolve`. r? @nrc
Configuration menu - View commit details
-
Copy full SHA for fc97771 - Browse repository at this point
Copy the full SHA fc97771View commit details -
Rollup merge of rust-lang#34109 - pnkfelix:fix-issue-34101, r=arielb1
Fix issue rust-lang#34101 Fix issue rust-lang#34101: do not track subcontent of type with dtor nor gather flags for untracked content. (Includes a regression test, which needed to go into `compile-fail/` due to weaknesses when combining `#[deny(warnings)]` with `tcx.sess.span_warn(..)`)
Configuration menu - View commit details
-
Copy full SHA for 100f082 - Browse repository at this point
Copy the full SHA 100f082View commit details -
Rollup merge of rust-lang#34129 - jviide:from-string-box-error, r=ste…
…veklabnik Remove a gotcha from book/error-handling.md The book's "Error handling with `Box<Error>`" section talks about `Box<Error>`. In the actual example `Box<Error + Send + Sync>` is used instead so that the corresponding From impls could be used to convert a plain string to an error type. Rust 1.7 added support for conversion from `&str`/`String` to `Box<Error>`, so this gotcha and later references to it can now be removed. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for c71db95 - Browse repository at this point
Copy the full SHA c71db95View commit details -
Rollup merge of rust-lang#34133 - m-decoster:master, r=GuillaumeGomez
Add explanations for E0503 and E0508. (cannot use `..` because it was mutably borrowed, cannot move out of type `..`, a non-copy fixed-size array) Part of rust-lang#32777.
Configuration menu - View commit details
-
Copy full SHA for c0f3647 - Browse repository at this point
Copy the full SHA c0f3647View commit details -
Rollup merge of rust-lang#34136 - imjacobclark:ice-test-case-25579, r…
…=nikomatsakis Test case for borrowk ICE rust-lang#25579 r? @nikomatsakis Fixes rust-lang#25579
Configuration menu - View commit details
-
Copy full SHA for 20f4d99 - Browse repository at this point
Copy the full SHA 20f4d99View commit details -
Rollup merge of rust-lang#34145 - matklad:any-docs, r=steveklabnik
docs: simplify wording It took me more then a moment to decipher "with no non-`'static`" thing :) "`'static` type" should say the same thing more clearly. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for c7b9ee2 - Browse repository at this point
Copy the full SHA c7b9ee2View commit details