Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Suggest x build library for a custom toolchain that fails to load core" #113289

Closed
wants to merge 1 commit into from
Closed

Revert "Suggest x build library for a custom toolchain that fails to load core" #113289

wants to merge 1 commit into from

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented Jul 3, 2023

Reverts #113259

r? @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2023
@lcnr
Copy link
Contributor

lcnr commented Jul 3, 2023

closing in favor of #113288 as that one is already approved

@lcnr lcnr closed this Jul 3, 2023
@mu001999 mu001999 deleted the fix/rev-113259 branch July 3, 2023 12:50
@Noratrieb
Copy link
Member

thank you for putting up the revert, we raced^^
this was a bit unfortunate and I'm not sure about the nicest way to fix it. Maybe we can make it so that it doesn't emit the nicer error when -Zui-testing is enabled? not sure whether that's nice though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mu001999 @lcnr @Noratrieb @jyn514 @rustbot