Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Suggest x build library for a custom toolchain that fails to load core" #113288

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

Noratrieb
Copy link
Member

@Noratrieb Noratrieb commented Jul 3, 2023

This reverts commit b913f55.

CI builds with profile=nightly, causing different test output.

Making the output depend on the release channel was not a great idea and we have to be more careful with this.

I did not realize that the change could have such effects on test output but it's kinda obvious with hindsight >.<.

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2023
@Noratrieb
Copy link
Member Author

@bors r=10

@bors
Copy link
Contributor

bors commented Jul 3, 2023

📌 Commit 9aad59bf61193af23642d4da1117e647fd8d6e76 has been approved by 10

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2023
@Noratrieb
Copy link
Member Author

@bors r-
@bors p=10

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jul 3, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2023

📌 Commit 9aad59bf61193af23642d4da1117e647fd8d6e76 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2023
…o load `core`"

This reverts commit b913f55.

CI builds with profile=nightly, causing different test output.

Making the output depend on the release channel was not a great idea.
@Noratrieb
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jul 3, 2023

📌 Commit ba0f5dc has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 3, 2023

⌛ Testing commit ba0f5dc with merge 3ae0ef7...

@bors
Copy link
Contributor

bors commented Jul 3, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 3ae0ef7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2023
@bors bors merged commit 3ae0ef7 into rust-lang:master Jul 3, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jul 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3ae0ef7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.2%, -1.0%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.125s -> 670.578s (0.37%)

@Noratrieb Noratrieb deleted the revert-dev branch July 7, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants