Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #112415

Merged
merged 18 commits into from
Jun 8, 2023
Merged

Rollup of 9 pull requests #112415

merged 18 commits into from
Jun 8, 2023

Commits on Jun 1, 2023

  1. Avoid passing --cpu-features when empty

    Added in 12ac719, this logic always
    passed --cpu-features, even when the value was the empty string.
    tamird committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    cd43545 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Configuration menu
    Copy the full SHA
    edf342a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    3522baa View commit details
    Browse the repository at this point in the history
  2. Remove accidental comment

    clubby789 committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    053e6b8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    adbfd0d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fbe3a47 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c38d80e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. add a test for rust-lang#105709

    replace build with check
    
    Co-authored-by: Michael Goulet <michael@errs.io>
    
    use appropriate test name
    TaKO8Ki committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    5e57e27 View commit details
    Browse the repository at this point in the history
  2. Migrate item_opaque_type to Askama

    Migrate item_opaque_type to Askama
    
    Fix wrap_item parameters
    
    Fix to write
    sladyn98 committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    29a51e1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#112034 - sladyn98:migrate-opaque-ty, r=Guil…

    …laumeGomez
    
    Migrate `item_opaque_ty` to Askama
    
    This PR migrates `item_opaque_ty` to Askama
    
    Refers: rust-lang#108868
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    e7059f1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#112179 - tamird:no-empty-cpu-features, r=pe…

    …trochenkov
    
    Avoid passing --cpu-features when empty
    
    Added in 12ac719, this logic always
    passed --cpu-features, even when the value was the empty string.
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ad9d7e3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#112309 - kadiwa4:remove_is_terminal, r=albe…

    …rtlarsan68
    
    bootstrap: remove dependency `is-terminal`
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    737dbb0 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#112388 - GuillaumeGomez:migrate-gui-test-co…

    …lor-12, r=notriddle
    
    Migrate GUI colors test to original CSS color format
    
    Follow-up of rust-lang#111459.
    
    r? `@notriddle`
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    53ee185 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5b7eba6 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#112392 - jieyouxu:issue-112385, r=compiler-…

    …errors
    
    Fix ICE for while loop with assignment condition with LHS place expr
    
    Fixes rust-lang#112385.
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    80829ce View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#112394 - clubby789:remove-comment, r=petroc…

    …henkov
    
    Remove accidental comment
    
    Left this in in rust-lang#110092 while debugging, thanks to `@WaffleLapkin` for spotting
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    80c2648 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#112396 - WaffleLapkin:track_more_diagnostic…

    …s, r=compiler-errors
    
    Track more diagnostics in `rustc_expand`
    
    I wish we could lint this somehow...
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b3d1a83 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#112401 - WaffleLapkin:dont_compile_error, r…

    …=Nilstrieb
    
    Don't `use compile_error as print`
    
    I've spent **1.5 hours** debugging this while trying to compile rust-lang#112400, if we use `compile_error!`, we should not just forward user input to it, but issue a reasonable error message.
    
    The better solution would be to use a lint like `clippy::print_stdout`, but since we don't have clippy in CI, let's at least make the macro error better.
    
    Also note that some functions called here actually do use `println` (see for example `print_type_sizes` function).
    GuillaumeGomez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    cf5e0b0 View commit details
    Browse the repository at this point in the history