fix running Miri tests #110177
Merged
fix running Miri tests #110177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors r+ p=1 fixes miri subtree Let's land this for now and figure out how to get miri and bootstrap to talk to each other correctly |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 873ab04 with merge 873e0288d7c57992ac03b03651fe07b24805ff08... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
@bors retry linker error |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 873ab04 with merge c3a6d318d488b7eb9a3b88a9faf8c4e3fa322df6... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry Another linker error? tests/run-make/jobserver-error
|
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Oh, the linker error was from the previous failure. The bot was just slow. New failure is some PGO issue it seems? Anyway still spurious.
|
|
⌛ Testing commit 873ab04 with merge 063df5029d694aee09c60a03e07aa6adbfe522a8... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
What is even going on? @bors retry third unique spurious test failure in a row... this one in registry::not_found_permutations |
bors
added
S-waiting-on-bors
This was referenced Apr 14, 2023
|
☀️ Test successful - checks-actions |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Finished benchmarking commit (b0884a3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #108659 to fix #110102: the Miri test runner does not support any flags, they are interpreted as filters instead which leads to no tests being run.
I have not checked any of the other test runners for whether they are having any trouble with these flags.
Cc @pietroalbini @Mark-Simulacrum @jyn514