Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious CI failure: registry::not_found_permutations #11975

Closed
RalfJung opened this issue Apr 14, 2023 · 2 comments · Fixed by #11976
Closed

Spurious CI failure: registry::not_found_permutations #11975

RalfJung opened this issue Apr 14, 2023 · 2 comments · Fixed by #11976
Assignees
@ehuss
Labels
T-cargo Team: Cargo

Comments

@RalfJung
Copy link
Member

RalfJung commented Apr 14, 2023 •
edited
Loading

This bors CI failure was almost certainly spurious:

 thread 'registry::not_found_permutations' panicked at 'assertion failed: `(left == right)`
  left: `["/index/a-/b-/a-b-c", "/index/a-/b_/a-b_c", "/index/a_/b-/a_b-c", "/index/a_/b_/a_b_c"]`,
 right: `["/index/a-/b-/a-b-c", "/index/a_/b-/a_b-c", "/index/a-/b_/a-b_c", "/index/a_/b_/a_b_c"]`', src/tools/cargo/tests/testsuite/registry.rs:3187:5


failures:
    registry::not_found_permutations

I think this is the cargo test suite? Hard to say from the logs.
@RalfJung RalfJung added T-infra Team: infrastructure T-cargo Team: Cargo and removed T-infra Team: infrastructure labels Apr 14, 2023
@ehuss ehuss transferred this issue from rust-lang/rust Apr 14, 2023
@ehuss
Copy link
Contributor

ehuss commented Apr 14, 2023

Thanks for the report. I will fix this shortly.

In the future, please tag me or the cargo team for a cargo test issue. Otherwise there is a high chance the issue will just get lost in rust-lang/rust. I transferred this to rust-lang/cargo since it is an issue here.

@ehuss ehuss self-assigned this Apr 14, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Apr 14, 2023 via email

@ehuss ehuss mentioned this issue Apr 14, 2023
Merged
@bors bors closed this as completed in 7fb89f0 Apr 14, 2023
ehuss pushed a commit to ehuss/cargo that referenced this issue Apr 17, 2023
@bors @ehuss
Auto merge of rust-lang#11976 - ehuss:fix-not_found_permutations, r=e…
9009251 
…page

Fix flaky not_found_permutations test.

This fixes the `registry::not_found_permutations` test which would randomly fail since the order of http requests was not deterministic. The resolver can issue queries in parallel which can process requests out-of-order.

Fixes rust-lang#11975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehuss ehuss

Labels
T-cargo Team: Cargo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky not_found_permutations test. ehuss/cargo
2 participants
@ehuss @RalfJung