Edition micro refactor
#107508
Merged
Edition micro refactor
#107508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 31, 2023
`Edition` micro refactor r? `@oli-obk`
Comment on lines
+902
to
910
| /// Is this edition 2015? | ||
| pub fn rust_2015(&self) -> bool { | ||
| self.edition() == Edition::Edition2015 | ||
| self.edition().rust_2015() | ||
| } | ||
|
|
||
| /// Are we allowed to use features from the Rust 2018 edition? | ||
| pub fn rust_2018(&self) -> bool { | ||
| self.edition() >= Edition::Edition2018 | ||
| self.edition().rust_2018() | ||
| } |
There was a problem hiding this comment.
Wait, so rust_2015 is edition == 2015, but rust_2018 is edition >= 2018? That's a bit confusing IMO
There was a problem hiding this comment.
Maybe we could rename rust_2015.. or rename all the subsequent ones to at_least_rust_2018? idk
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 31, 2023
`Edition` micro refactor r? `@oli-obk`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2023
…llaumeGomez Rollup of 12 pull requests Successful merges: - rust-lang#106898 (Include both md and yaml ICE ticket templates) - rust-lang#107331 (Clean up eslint annotations and remove unused JS function) - rust-lang#107348 (small refactor to new projection code) - rust-lang#107354 (rustdoc: update Source Serif 4 from 4.004 to 4.005) - rust-lang#107412 (avoid needless checks) - rust-lang#107467 (Improve enum checks) - rust-lang#107486 (Track bound types like bound regions) - rust-lang#107491 (rustdoc: remove unused CSS from `.setting-check`) - rust-lang#107508 (`Edition` micro refactor) - rust-lang#107525 (PointeeInfo is advisory only) - rust-lang#107527 (rustdoc: stop making unstable items transparent) - rust-lang#107535 (Replace unwrap with ? in TcpListener doc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? `@compiler-errors` rust-lang#107508 (comment)
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? `@compiler-errors` rust-lang#107508 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? ``@compiler-errors`` rust-lang#107508 (comment)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 2, 2023
Rename `rust_2015` → `is_rust_2015` r? ```@compiler-errors``` rust-lang#107508 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk