Track bound types like bound regions #107486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Jan 30, 2023
| @@ -370,7 +370,7 @@ impl<'tcx> LowerInto<'tcx, chalk_ir::Ty<RustInterner<'tcx>>> for Ty<'tcx> { | |||
| ty::Placeholder(_placeholder) => { | |||
| chalk_ir::TyKind::Placeholder(chalk_ir::PlaceholderIndex { | |||
| ui: chalk_ir::UniverseIndex { counter: _placeholder.universe.as_usize() }, | |||
| idx: _placeholder.name.as_usize(), | |||
| idx: _placeholder.name.expect_anon() as usize, | |||
There was a problem hiding this comment.
I'm pretty sure that due to canonicalization, this will never be triggered.
In any case, I'm happpy with not having chalk support for bound types 😬 -- we also treat RePlaceholder very strangely below (always giving it an idx: 0)
compiler-errors
force-pushed
the
bound-ty-keep-name
branch
from
fec937e
to
0e98a16
Compare
|
@bors r+ rollup Except for the chalk use cases |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 31, 2023
…, r=oli-obk Track bound types like bound regions When we instantiate bound types into placeholder types, we throw away the names for some reason. These names are particularly useful for error reporting once we have `for<T>` binders. r? types
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 31, 2023
…, r=oli-obk Track bound types like bound regions When we instantiate bound types into placeholder types, we throw away the names for some reason. These names are particularly useful for error reporting once we have `for<T>` binders. r? types
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2023
…llaumeGomez Rollup of 12 pull requests Successful merges: - rust-lang#106898 (Include both md and yaml ICE ticket templates) - rust-lang#107331 (Clean up eslint annotations and remove unused JS function) - rust-lang#107348 (small refactor to new projection code) - rust-lang#107354 (rustdoc: update Source Serif 4 from 4.004 to 4.005) - rust-lang#107412 (avoid needless checks) - rust-lang#107467 (Improve enum checks) - rust-lang#107486 (Track bound types like bound regions) - rust-lang#107491 (rustdoc: remove unused CSS from `.setting-check`) - rust-lang#107508 (`Edition` micro refactor) - rust-lang#107525 (PointeeInfo is advisory only) - rust-lang#107527 (rustdoc: stop making unstable items transparent) - rust-lang#107535 (Replace unwrap with ? in TcpListener doc) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we instantiate bound types into placeholder types, we throw away the names for some reason. These names are particularly useful for error reporting once we have
for<T>binders.r? types