Rollup of 4 pull requests #102690
Closed
Rollup of 4 pull requests #102690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 76a3b60 converted code headers to real headers, `display: block` is now the default.
modified: compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs modified: src/test/ui/error-codes/E0283.stderr modified: src/test/ui/error-codes/E0790.stderr modified: src/test/ui/traits/static-method-generic-inference.stderr modified: src/test/ui/type/issue-101866.stderr
The rls stub is a simple stable tool, which doesn't need compiler libs.
…rn-for-returning-function-error, r=compiler-errors Slightly improve no return for returning function error Fixes rust-lang#100607 The rationale is that absolute beginners will be slightly confused as to why certain lines of code in a function does not require a semicolon. (I have actually witness a beginner having this confusion). Hence, a slight rationale is added "to return this value", which signals to the user that after removing said semicolon the value is returned resolving that error. However, if this is not desirable, I welcome any other suggestions. Thanks.
…splay-block, r=GuillaumeGomez
rustdoc: remove no-op CSS `.code-header { display: block }`
Since 76a3b60 converted code headers to real headers, `display: block` is now the default.
…piler-errors follow-up fix about 101866 to print the self type. modified: compiler/rustc_trait_selection/src/traits/error_reporting/mod.rs modified: src/test/ui/error-codes/E0283.stderr modified: src/test/ui/error-codes/E0790.stderr modified: src/test/ui/traits/static-method-generic-inference.stderr modified: src/test/ui/type/issue-101866.stderr
Don't build the compiler before building rls The rls stub is a simple stable tool, which doesn't need compiler libs. (Similar to rust-lang#97511)
rustbot
added
T-bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
.code-header { display: block }#102662 (rustdoc: remove no-op CSS.code-header { display: block })Failed merges:
in-band#102672 (rustdoc: remove unused CSS classin-band)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup