Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build the compiler before building rls #102686

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 5, 2022

The rls stub is a simple stable tool, which doesn't need compiler libs.
(Similar to #97511)

The rls stub is a simple stable tool, which doesn't need compiler libs.
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 5, 2022
@rust-highfive
Copy link
Collaborator

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2022
@jyn514
Copy link
Member

jyn514 commented Oct 5, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 5, 2022

📌 Commit 3042b78 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2022
notriddle added a commit to notriddle/rust that referenced this pull request Oct 5, 2022
Don't build the compiler before building rls

The rls stub is a simple stable tool, which doesn't need compiler libs.
(Similar to rust-lang#97511)
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 5, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#102574 (Make Hash{Set,Map}::with_hasher unstably const)
 - rust-lang#102650 (Slightly improve no return for returning function error)
 - rust-lang#102662 (rustdoc: remove no-op CSS `.code-header { display: block }`)
 - rust-lang#102670 (follow-up fix about 101866 to print the self type.)
 - rust-lang#102686 (Don't build the compiler before building rls)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 40ce4af into rust-lang:master Oct 5, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 5, 2022
@cuviper cuviper deleted the rls-tool_std branch October 15, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants