Add list of recognized repr attributes to the unrecognized repr error #101486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Sep 6, 2022
| @@ -1658,6 +1658,7 @@ impl CheckAttrVisitor<'_> { | |||
| E0552, | |||
| "unrecognized representation hint" | |||
| ) | |||
| .help("valid reprs are `C`, `align`, `packed`, `transparent`, `simd`, `i8`, `u8`, `i16`, `u16`, `i32`, `u32`, `i64`, `u64`, `i128`, `u128`, `isize`, `usize`") | |||
There was a problem hiding this comment.
Ideally this list would be generated from some canonical source.
There was a problem hiding this comment.
Unfortunately we don't seem to have such a source, and there's code in another place that also replicates a lot of these checks and they all just seem to check symbols.
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 7, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#101451 (Add incremental test for changing struct name in assoc type.) - rust-lang#101468 (fix RPIT ICE for implicit HRTB when missing dyn) - rust-lang#101481 (Fix compile errors for uwp-windows-msvc targets) - rust-lang#101484 (Remove dead broken code from const zst handling in backends) - rust-lang#101486 (Add list of recognized repr attributes to the unrecognized repr error) - rust-lang#101488 (rustdoc: remove unused CSS `#results > table`) - rust-lang#101491 (rustdoc: remove outdated CSS `.sub-variant > div > .item-info`) - rust-lang#101497 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.