Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround cargo issue on appveyor #4624

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Oct 4, 2019

Use absolute paths for cargo and rustfmt to workaround rust-lang/cargo#7475.

Appveyor passed on my fork: https://ci.appveyor.com/project/sinkuu/rust-clippy/builds/27870367

changelog: none

@llogiq
Copy link
Contributor

llogiq commented Oct 4, 2019

Thanks, let's try this. @bors r+

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

📌 Commit 248251b has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

⌛ Testing commit 248251b with merge ad1a8f6...

bors added a commit that referenced this pull request Oct 4, 2019
Workaround cargo issue on appveyor

Use absolute paths for `cargo` and `rustfmt` to workaround rust-lang/cargo#7475.

Appveyor passed on my fork: https://ci.appveyor.com/project/sinkuu/rust-clippy/builds/27870367
@bors
Copy link
Collaborator

bors commented Oct 4, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented Oct 4, 2019

@bors retry

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

⌛ Testing commit 248251b with merge b824f02...

bors added a commit that referenced this pull request Oct 4, 2019
Workaround cargo issue on appveyor

Use absolute paths for `cargo` and `rustfmt` to workaround rust-lang/cargo#7475.

Appveyor passed on my fork: https://ci.appveyor.com/project/sinkuu/rust-clippy/builds/27870367

changelog: none
@sinkuu
Copy link
Contributor Author

sinkuu commented Oct 4, 2019

Sorry, I fogot changelog: line in PR description.

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: llogiq
Pushing b824f02 to master...

@bors bors merged commit 248251b into rust-lang:master Oct 4, 2019
@sinkuu sinkuu deleted the workaround_cargo branch October 4, 2019 06:11
bors added a commit that referenced this pull request Oct 8, 2019
Revert "Workaround cargo bug on Windows"

[Cargo is fixed on rust master](rust-lang/rust#65186). This reverts PR #4624.

Fixes #4638

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants