Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use windows-sdk-10.1 to avoid installation failure #4621

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Use windows-sdk-10.1 to avoid installation failure #4621

merged 1 commit into from
Oct 4, 2019

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Oct 3, 2019 •
edited
Loading

This fixes installation failure on Windows on Travis but we need to fix rustfmt issue first to pass the CI completely.

changelog: none

@phansch
Copy link
Member

phansch commented Oct 4, 2019

Not sure if this is still needed with #4624, but I'm curious how this upgrade interacts with the merged PR.

@bors try

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

⌛ Trying commit 2af1995 with merge fb9b0d9...

bors added a commit that referenced this pull request Oct 4, 2019
@bors
Auto merge of #4621 - JohnTitor:fix-windows, r=<try>
fb9b0d9 
Use windows-sdk-10.1 to avoid installation failure

This fixes installation failure on Windows on Travis but we need to fix rustfmt issue first to pass the CI completely.

changelog: none
@JohnTitor
Copy link
Member Author

Note that this affects Travis' Windows job only. This fixes the installation failure on Travis' Windows job. This is unrelated to recently fmt failure.

@phansch
Copy link
Member

phansch commented Oct 4, 2019 •
edited
Loading

Note that this affects Travis' Windows job only. This fixes the installation failure on Travis' Windows job. This is unrelated to recently fmt failure.

Oh right, then they don't interact at all.

@bors r+

thanks! (cancelled the try build)

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

📌 Commit 2af1995 has been approved by phansch

bors added a commit that referenced this pull request Oct 4, 2019
@bors
Auto merge of #4621 - JohnTitor:fix-windows, r=phansch
fdb8e4e 
Use windows-sdk-10.1 to avoid installation failure

This fixes installation failure on Windows on Travis but we need to fix rustfmt issue first to pass the CI completely.

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 4, 2019

⌛ Testing commit 2af1995 with merge fdb8e4e...

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

📌 Commit 2af1995 has been approved by phansch

bors added a commit that referenced this pull request Oct 4, 2019
@bors
Auto merge of #4621 - JohnTitor:fix-windows, r=phansch
933df2a 
Use windows-sdk-10.1 to avoid installation failure

This fixes installation failure on Windows on Travis but we need to fix rustfmt issue first to pass the CI completely.

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 4, 2019

⌛ Testing commit 2af1995 with merge 933df2a...

@bors
Copy link
Collaborator

bors commented Oct 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 933df2a to master...

@bors bors merged commit 2af1995 into rust-lang:master Oct 4, 2019
@JohnTitor
Copy link
Member Author

Hmm, the installation failure is fixed but another error has occurred. If it's not temporary, I'll investigate later.

@JohnTitor JohnTitor deleted the fix-windows branch October 4, 2019 10:30
@mati865
Copy link
Contributor

mati865 commented Oct 4, 2019

@JohnTitor probably rustup cannot replace binary because it's still running (or there is another hook attached).
Given the fact Clippy should migrate to Github Action or Azure Pipelines soon I think it's not worth wasting time on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnTitor @phansch @bors @mati865