Improve cast_ptr_alignment lint #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a changelog entry to the PR body |
flip1995
reviewed
Jul 7, 2019
|
@Manishearth @flip1995 done and done, thanks :) |
Manishearth
approved these changes
Jul 7, 2019
skade
force-pushed
the
improve-cast-alignment
branch
from
696a8e1
to
758b89a
Compare
|
Train WiFi, where seconds become hours. I rewrote the patch a little. It now computes the layout and then does member accesses everywhere. That makes the accesses more verbose, but the whole things stays consistent. |
skade
force-pushed
the
improve-cast-alignment
branch
from
758b89a
to
c5da13f
Compare
flip1995
reviewed
Jul 9, 2019
* print alignment in bytes in the lint message * ignore ZST left-hand types
skade
force-pushed
the
improve-cast-alignment
branch
from
c5da13f
to
aa72cac
Compare
|
Added @flip1995's suggestion, currently running through CI. |
|
@bors r+ |
|
📌 Commit aa72cac has been approved by |
bors
added a commit
that referenced
this pull request
Jul 9, 2019
Improve cast_ptr_alignment lint <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [x] Followed [lint naming conventions][lint_naming] - [x] Added passing UI tests (including committed `.stderr` file) - [x] `cargo test` passes locally - [x] Executed `util/dev update_lints` - [x] Added lint documentation - [x] Run `cargo fmt` Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> * print alignment in bytes in the lint message * ignore ZST left-hand types Fixes #3797 and #4256 changelog: * `cast_ptr_alignment`: Print alignment in bytes in the lint message * `cast_ptr_alignment`: Ignore casting from ZST left-hand types
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3797 and #4256
changelog:
cast_ptr_alignment: Print alignment in bytes in the lint messagecast_ptr_alignment: Ignore casting from ZST left-hand types