cast_ptr_alignment should not call out ZST -> to other pointers
#4256
Comments
bors
added a commit
that referenced
this issue
Jul 9, 2019
Improve cast_ptr_alignment lint <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [x] Followed [lint naming conventions][lint_naming] - [x] Added passing UI tests (including committed `.stderr` file) - [x] `cargo test` passes locally - [x] Executed `util/dev update_lints` - [x] Added lint documentation - [x] Run `cargo fmt` Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> * print alignment in bytes in the lint message * ignore ZST left-hand types Fixes #3797 and #4256 changelog: * `cast_ptr_alignment`: Print alignment in bytes in the lint message * `cast_ptr_alignment`: Ignore casting from ZST left-hand types
|
Fixed by #4257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is currently caught by
cast_ptr_alignment.I discussed this with @Manishearth last night and we came to the conclusion that we don't have enough information at this point to lint this case. It's a common pattern to cast from ZST pointers to larger types and the lint will always trigger here. We have to assume here that the user knows where the pointer was produced. We can't draw any conclusions from the left-hand pointer.
The situation is similar to
c_void, which is already ignored.The text was updated successfully, but these errors were encountered: