Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: rewrite #[derive] removal to be based on AST (take 2) #8796

Merged
merged 3 commits into from
May 11, 2021
Merged

internal: rewrite #[derive] removal to be based on AST (take 2) #8796

merged 3 commits into from
May 11, 2021

Conversation

jonas-schievink
Copy link
Contributor

Second attempt of #8443, this uses syntactical attribute offsets in hir_expand, and changes attr.rs to make those easy to derive.

This will make it easy to add similar attribute removal for attribute macros, unblocking them.

@jonas-schievink
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 11, 2021

@bors bors bot merged commit 6afd9b2 into rust-lang:master May 11, 2021
@jonas-schievink jonas-schievink deleted the hir_expand-attrs branch May 11, 2021 17:59
bors bot added a commit that referenced this pull request May 11, 2021
8806: fix: Strip delimiter from fn-like macro invocations r=jonas-schievink a=jonas-schievink

This broke in #8796 (again), the fix is easy though

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
bors bot added a commit that referenced this pull request May 11, 2021
8806: fix: Strip delimiter from fn-like macro invocations r=jonas-schievink a=jonas-schievink

This broke in #8796 (again), the fix is easy though

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants