Rewrite #[derive] removal code to be based on AST
#8443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin0cheng
reviewed
Apr 9, 2021
crates/hir_expand/src/input.rs
Outdated
| if let Some(name) = | ||
| attr.path().and_then(|path| path.as_single_segment()).and_then(|seg| seg.name_ref()) | ||
| { | ||
| if name.as_name().to_string() == "derive" { |
|
bors r+ |
|
changelog skip |
bors bot
added a commit
that referenced
this pull request
May 11, 2021
8796: internal: rewrite `#[derive]` removal to be based on AST (take 2) r=jonas-schievink a=jonas-schievink Second attempt of #8443, this uses syntactical attribute offsets in `hir_expand`, and changes `attr.rs` to make those easy to derive. This will make it easy to add similar attribute removal for attribute macros, unblocking them. Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now remove any
#[derive]before and including the one we want to expand, in themacro_argquery.The same infra will be needed by attribute macros (except we only remove the attribute we're expanding, not any preceding ones).
Part of #8434 (doesn't implement the cfg-expansion yet, because that's more difficult)