Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add custom completer for completing test names #14548

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: Add custom completer for completing test names #14548

merged 1 commit into from
Sep 17, 2024

Conversation

shannmu
Copy link
Contributor

@shannmu shannmu commented Sep 15, 2024

What does this PR try to resolve?

Tracking issue #14520

Add custom completer for cargo test --test <TAB>

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2024
@bors
Copy link
Collaborator

bors commented Sep 16, 2024

☔ The latest upstream changes (presumably #14533) made this pull request unmergeable. Please resolve the merge conflicts.

@epage
Copy link
Contributor

epage commented Sep 17, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 17, 2024

📌 Commit f47e2a5 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2024
@bors
Copy link
Collaborator

bors commented Sep 17, 2024

⌛ Testing commit f47e2a5 with merge 25456ea...

@bors
Copy link
Collaborator

bors commented Sep 17, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing 25456ea to master...

@bors bors merged commit 25456ea into rust-lang:master Sep 17, 2024
21 of 22 checks passed
@epage epage mentioned this pull request Sep 17, 2024
Open
20 tasks
@epage epage deleted the _cargo_test_names branch September 18, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epage epage

Labels
A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shannmu @rustbot @bors @epage