Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add custom completer for completing bin names #14533

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat: Add custom completer for completing bin names #14533

merged 1 commit into from
Sep 16, 2024
+55 −15

Conversation

shannmu
Copy link
Contributor

@shannmu shannmu commented Sep 11, 2024

What does this PR try to resolve?

Tracking issue #14520

Add custom completer for cargo build --bin=<TAB>

@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2024
@shannmu
Copy link
Contributor Author

shannmu commented Sep 11, 2024

r? @epage

@rustbot rustbot assigned epage and unassigned ehuss Sep 11, 2024
@epage
Copy link
Contributor

epage commented Sep 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 16, 2024

📌 Commit 93fc564 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2024
@bors
Copy link
Collaborator

bors commented Sep 16, 2024

⌛ Testing commit 93fc564 with merge 7984efa...

@bors
Copy link
Collaborator

bors commented Sep 16, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing 7984efa to master...

@bors bors merged commit 7984efa into rust-lang:master Sep 16, 2024
22 checks passed
This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
@epage epage mentioned this pull request Sep 17, 2024
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage left review comments

Assignees

@epage epage

Labels
A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shannmu @rustbot @epage @bors @ehuss