Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-workflow hooks on all comment/auto triggered commands. (#43) #1418

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

nishkrishnan
Copy link
Contributor

Allows you to actually do dynamic configuration generation since unlock command can be run at anytime which would then nuke the working directory and the PR would need to be opened again from scratch.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1418 (7b58de5) into master (5e4bde4) will increase coverage by 0.24%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
+ Coverage   69.40%   69.64%   +0.24%     
==========================================
  Files          93       93              
  Lines        6291     6280      -11     
==========================================
+ Hits         4366     4374       +8     
+ Misses       1543     1529      -14     
+ Partials      382      377       -5     
Impacted Files Coverage Δ
server/events/runtime/pre_workflow_hook_runner.go 100.00% <ø> (ø)
server/events_controller.go 56.07% <ø> (-0.32%) ⬇️
server/events/command_runner.go 66.66% <50.00%> (+1.66%) ⬆️
server/events/delete_lock_command.go 75.00% <100.00%> (+1.92%) ⬆️
server/events/pre_workflow_hooks_command_runner.go 100.00% <100.00%> (+35.41%) ⬆️
server/events/yaml/valid/global_cfg.go 89.33% <100.00%> (+0.07%) ⬆️
server/server.go 64.91% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4bde4...ada0ccd. Read the comment docs.

@msarvar
Copy link
Contributor

msarvar commented Feb 18, 2021

This should fix following two bugs

  1. Fixes pre-workflow-hooks not logging errors Atlantis doesn't log pre_workflow_hooks #1371
  2. Prevents pre-workflow-hook from locking and cloning the dir if there are no hooks registered. PreWorkflowHook do not respect SkipCloneNoChanges #1342

Copy link
Contributor

@acastle acastle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nishkrishnan nishkrishnan merged commit 8598c37 into runatlantis:master Feb 22, 2021
msarvar added a commit that referenced this pull request Mar 18, 2021
After #1418 was merged pre-workflow-hooks are executed before every
command. Removed the note and added some more explanation to the docs
msarvar added a commit that referenced this pull request Mar 18, 2021
After #1418 was merged pre-workflow-hooks are executed before every
command. Removed the note and added some more explanation to the docs
@mikecutalo mikecutalo deleted the nish/update-pwh branch June 8, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants