-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec/PendingWithoutReason
in 2.16.0 gives false positive in factories with pending
attribute
#1565
Comments
Fixed in 2.17 |
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
@pirj I checked here, and it seems to be false positive in the following cases where a block is given to pending/skip. |
Provided there is a cop that is watching over in-example ‘pending’/‘skip’ with blocks, I’m fine with fixing this false positive in ‘PendingWiyhoutReason’ that additionally avoids duplicate offences, and to completely split responsibilities. |
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
… example and pending/skip with block Fix: rubocop#1565
This is related to the "False positive for
RSpec/PendingWithoutReason
in 2.16.0 when object has a method pending" issue, because if those objects have any factory, we still have this false positive offense:Not sure the best way to handle that. Indeed, in our project, we could exclude the
spec/factories
path for this cop in.rubocop.yml
, but maybe this exclusion should be handled by the cop itself? Depending if you consider that using factory_bot along withrspec
is very usual, or where this responsibility stands. WDYT?The text was updated successfully, but these errors were encountered: