RSpec/PendingWithoutReason in 2.16.0 gives false positive in factories with pending attribute

[RDeckard]

This is related to the "False positive for RSpec/PendingWithoutReason in 2.16.0 when object has a method pending" issue, because if those objects have any factory, we still have this false positive offense:

Not sure the best way to handle that. Indeed, in our project, we could exclude the spec/factories path for this cop in .rubocop.yml, but maybe this exclusion should be handled by the cop itself? Depending if you consider that using factory_bot along with rspec is very usual, or where this responsibility stands. WDYT?

[pirj]

Fixed in 2.17

[ydah]

@pirj I checked here, and it seems to be false positive in the following cases where a block is given to pending/skip.
So The following Pull Request was opened:

• Fix a false positive for RSpec/PendingWithoutReason when not inside example and pending/skip with block #1566

[pirj]

Provided there is a cop that is watching over in-example ‘pending’/‘skip’ with blocks, I’m fine with fixing this false positive in ‘PendingWiyhoutReason’ that additionally avoids duplicate offences, and to completely split responsibilities.