Fix a false positive for RSpec/PendingWithoutReason when not inside…

… example and pending/skip with block

Fix: rubocop#1565

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+- Fix a false positive for `RSpec/PendingWithoutReason` when not inside example and pending/skip with block. ([@ydah])
+
 ## 2.18.0 (2023-01-16)
 
 - Extract Capybara cops to a separate repository. ([@pirj])

lib/rubocop/cop/rspec/pending_without_reason.rb

@@ -60,8 +60,8 @@ class PendingWithoutReason < Base
         MSG = 'Give the reason for pending or skip.'
 
         # @!method pending_by_example_method?(node)
-        def_node_matcher :pending_by_example_method?, block_pattern(<<~PATTERN)
-          #Examples.pending
+        def_node_matcher :pending_by_example_method?, <<~PATTERN
+          (block (send nil? #Examples.pending (...)) args ...)
         PATTERN
 
         # @!method pending_by_metadata_without_reason?(node)
@@ -70,8 +70,8 @@ class PendingWithoutReason < Base
         PATTERN
 
         # @!method skipped_by_example_method?(node)
-        def_node_matcher :skipped_by_example_method?, block_pattern(<<~PATTERN)
-          #Examples.skipped
+        def_node_matcher :skipped_by_example_method?, <<~PATTERN
+          (block (send nil? #Examples.skipped (...)) args ...)
         PATTERN
 
         # @!method skipped_by_example_group_method?(node)
@@ -89,17 +89,22 @@ class PendingWithoutReason < Base
 
         # @!method without_reason?(node)
         def_node_matcher :without_reason?, <<~PATTERN
-          (send nil? ${:pending :skip})
+          (block ... $(send nil? {:pending :skip}))
         PATTERN
 
         def on_send(node)
           if pending_without_reason?(node)
             add_offense(node, message: 'Give the reason for pending.')
           elsif skipped_without_reason?(node)
             add_offense(node, message: 'Give the reason for skip.')
-          elsif without_reason?(node) && example?(node.parent)
-            add_offense(node,
-                        message: "Give the reason for #{node.method_name}.")
+          end
+        end
+
+        def on_block(node)
+          return unless Examples.all(node.send_node.method_name)
+
+          without_reason?(node) do |pending_node|
+            add_offense(pending_node, message: "Give the reason for #{pending_node.method_name}.")
           end
         end
 

spec/rubocop/cop/rspec/pending_without_reason_spec.rb

@@ -65,6 +65,32 @@
     end
   end
 
+  context 'when pending by pending step without reason ' \
+          'and not inside example with block' do
+    it 'registers no offense' do
+      expect_no_offenses(<<~RUBY)
+        FactoryBot.define do
+          factory :task do
+            pending { true }
+          end
+        end
+      RUBY
+    end
+  end
+
+  context 'when skipped by skip step without reason ' \
+          'and not inside example with block' do
+    it 'registers no offense' do
+      expect_no_offenses(<<~RUBY)
+        FactoryBot.define do
+          factory :task do
+            skip { true }
+          end
+        end
+      RUBY
+    end
+  end
+
   context 'when pending with receiver' do
     it 'registers no offense' do
       expect_no_offenses(<<~RUBY)