Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for RSpec/PendingWithoutReason in 2.16.0 when object has a method pending #1549

Closed
sihu opened this issue Jan 12, 2023 · 2 comments

Comments

@sihu
Copy link

sihu commented Jan 12, 2023

Hi rubocop-rspec team,

I noticed that we had a false positive in our project (at least i think it's a false positive): There is a object with an enum state with the value pending. In our test we are querying all pending transations. I would expect that the spec does not consider this as an issue.

    it 'approves the transaction' do
      expect do
        request
      end.to change(Transaction.pending, :count).from(1).to(0)

(Ruby 2.7.7, rubocop 1.43.0, rubocop-ast 1.24.1, rubocop-rspec 2.16.0)

@sihu sihu changed the title False positive for RSpec/Pending in 2.16.0 when object has a method pending False positive for RSpec/PendingWithoutReason in 2.16.0 when object has a method pending Jan 12, 2023
@ydah
Copy link
Member

ydah commented Jan 13, 2023

Thank you for your report!
This issue has been fixed in #1515 and #1516, but not yet released. Please wait for the next release.

@pirj
Copy link
Member

pirj commented Jan 13, 2023

My apologies for a temporary inconvenience.

@bquorning does it make sense to release bug fixes in a patch release before 2.17 with Capybara extraction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants