Lazy load type mappings #2300
Closed
Lazy load type mappings #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Rails `7-0-stable` branch
Update README for 7.0 [skip ci]
Merge pull request rsim#2224 from yahonda/update_readme_for_70
Prepare release v7.0.0 [skip ci]
Merge pull request rsim#2230 from yahonda/prepare_v700
Add `if_exists` option to `remove_index`
all attributes serialized before writing
Merge pull request rsim#2219 from koic/add_if_exists_to_remove_index
Merge pull request rsim#2203 from akostadinov/master
Add `ruby-oci8` as dependency only for CRuby
…plaltes Require 'activerecord', not 'rails' not to attempt to install digest
Bump Ruby versions at Travis CI
Merge pull request rsim#2240 from yahonda/diag2238
CI against Ruby 3.1 at GitHub Actions
Merge pull request rsim#2235 from yahonda/add_ruby31_to_github_actions
Prepare release v7.0.1 [skip ci]
Merge pull request rsim#2246 from yahonda/prepare_v701
Merge pull request rsim#2249 from swamp09/fix_columns_for_distinct
Prepare release v7.0.2 [skip ci]
Merge pull request rsim#2254 from yahonda/prepare_v702
In hopes of allowing the configuration for emulate_booleans to get set before it is evaluated.
|
Would you also change your branch based on the current master branch? It looks this pull request is trying to merge something from release7-0 branch with your commits to the master branch. |
|
Cleaner version without the no-op release70 commits mixed in here: #2301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This time against the master branch)
This appears to fix issue #2256. I believe it should have the same memory implications as the intention in #2199. The type maps are loaded once when they are first called. Only one instance of the mapping is ever created.
Fortunately this was enough to solve the problem, but if there were a need, this could easily be worked into the clear_cache! API to reset it at a later point in the application just by setting the @type_map to nil.