Add if_exists option to remove_index
#2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to rails/rails#38967. The `if_exists` option has been introduced since Rails 6.1.
|
At least this pull request needs this test passed. Would you execute it and see if it works? |
|
Ah, your suggestion makes sense! However unfortunately it cannot be executed because my Oracle adapter development environment is out of order yet. |
|
Understood. Let me try running this test with this pull request. |
|
I have confirmed this pull request passes the test added via rails/rails#38967 $ ARCONN=oracle bin/test test/cases/migration/index_test.rb -n test_remove_index_which_does_not_exist_doesnt_raise_with_option
Using oracle
Run options: -n test_remove_index_which_does_not_exist_doesnt_raise_with_option --seed 16315
# Running:
.
Finished in 2.123981s, 0.4708 runs/s, 0.4708 assertions/s.
1 runs, 1 assertions, 0 failures, 0 errors, 0 skips
$ |
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Dec 21, 2021
Add `if_exists` option to `remove_index`
yahonda
added a commit
that referenced
this pull request
Dec 21, 2021
Merge pull request #2219 from koic/add_if_exists_to_remove_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to rails/rails#38967.
The
if_existsoption has been introduced since Rails 6.1.